Re: [PATCH] worktree: add -z option for list subcommand
Hi Jean-Noël
On 28/02/2022 09:47, Jean-Noël Avila wrote:
Show 23 quoted lines
> Le 25/02/2022 à 16:08, Phillip Wood via GitGitGadget a écrit :
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>>
>> @@ -696,6 +702,8 @@ static int list(int ac, const char **av, const
>> char *prefix)
>> usage_with_options(worktree_usage, options);
>> else if (verbose && porcelain)
>> die(_("options '%s' and '%s' cannot be used together"),
>> "--verbose", "--porcelain");
>> + else if (!line_terminator && !porcelain)
>> + die(_("'-z' requires '--porcelain'"));
>> else {
>> struct worktree **worktrees = get_worktrees();
>> int path_maxlen = 0, abbrev = DEFAULT_ABBREV, i;
>
>
> Please better use
>
> die(_("the option '%s' requires '%s'"), "-z", "--porcelain");
>
>
> In order to make a no-op for translators.Will do, thanks for the suggestion
Phillip
Show 5 quoted lines
>
> Best regards,
>
> JN
>