git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 28, 2015, 21:49 UTC
Message-ID
<CAPig+cSiCR3OdYf=4BnaiS8PuSKxd7OPPxOUQYyZpBjkQ15LQQ@mail.gmail.com>
In-Reply-To
<1437982035-6658-7-git-send-email-Karthik.188@gmail.com>
On Mon, Jul 27, 2015 at 3:27 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
Show 35 quoted lines
> From: Karthik Nayak <karthik.188@gmail.com>
>
> Since 'ref-filter' only has an option to match path names add an
> option for plain fnmatch pattern-matching.
>
> This is to support the pattern matching options which are used in `git
> tag -l` and `git branch -l` where we can match patterns like `git tag
> -l foo*` which would match all tags which has a "foo*" pattern.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
> diff --git a/ref-filter.c b/ref-filter.c
> index 26eb26c..597b189 100644
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -946,6 +946,32 @@ static int commit_contains(struct ref_filter *filter, struct commit *commit)
>
>  /*
>   * Return 1 if the refname matches one of the patterns, otherwise 0.
> + * A pattern can be a literal prefix (e.g. a refname "refs/heads/master"
> + * matches a pattern "refs/heads/mas") or a wildcard (e.g. the same ref
> + * matches "refs/heads/mas*", too).
> + */
> +static int match_pattern(const char **patterns, const char *refname)
> +{
> +       /*
> +        * When no '--format' option is given we need to skip the prefix
> +        * for matching refs of tags and branches.
> +        */
> +       if (skip_prefix(refname, "refs/tags/", &refname))
> +               ;
> +       else if (skip_prefix(refname, "refs/heads/", &refname))
> +               ;
> +       else if (skip_prefix(refname, "refs/remotes/", &refname))
> +               ;
Or, more concisely:
    skip_prefix(refname, "refs/tags/", &refname) ||
    skip_prefix(refname, "refs/heads/", &refname) ||
    skip_prefix(refname, "refs/remotes/", &refname);
since || short-circuits. No need for the 'if' or cascading 'else if's.
Show 6 quoted lines
> +       for (; *patterns; patterns++) {
> +               if (!wildmatch(*patterns, refname, 0, NULL))
> +                       return 1;
> +       }
> +       return 0;
> +}
Previous: Karthik NayakNext: Karthik Nayak
Message 30 of 38 in “port tag.c to use ref-filter APIs”
  1. 00/11 port tag.c to use ref-filter APIsKarthik Nayak, Jul 27, 2015
  2. 01/11 ref-filter: introduce 'ref_formatting_state'Karthik Nayak, Jul 27, 2015
  3. 02/11 ref-filter: make `color` use `ref_formatting_state`Karthik Nayak, Jul 27, 2015
  4. Matthieu MoyJul 27, 2015
  5. Junio C HamanoJul 27, 2015
  6. Karthik NayakJul 27, 2015
  7. Karthik NayakJul 27, 2015
  8. Matthieu MoyJul 27, 2015
  9. Karthik NayakJul 27, 2015
  10. 03/11 ref-filter: add option to pad atoms to the rightKarthik Nayak, Jul 27, 2015
  11. Matthieu MoyJul 27, 2015
  12. Junio C HamanoJul 27, 2015
  13. Matthieu MoyJul 27, 2015
  14. Karthik NayakJul 27, 2015
  15. Matthieu MoyJul 27, 2015
  16. Karthik NayakJul 27, 2015
  17. Junio C HamanoJul 27, 2015
  18. Karthik NayakJul 27, 2015
  19. Eric SunshineJul 28, 2015
  20. Karthik NayakJul 29, 2015
  21. 04/11 ref-filter: add option to filter only tagsKarthik Nayak, Jul 27, 2015
  22. 05/11 ref-filter: support printing N lines from tag annotationKarthik Nayak, Jul 27, 2015
  23. 06/11 ref-filter: add support to sort by versionKarthik Nayak, Jul 27, 2015
  24. 07/11 ref-filter: add option to match literal patternKarthik Nayak, Jul 27, 2015
  25. Matthieu MoyJul 27, 2015
  26. Karthik NayakJul 27, 2015
  27. Karthik NayakJul 27, 2015
  28. Matthieu MoyJul 27, 2015
  29. Karthik NayakJul 27, 2015
  30. Eric SunshineJul 28, 2015
  31. Karthik NayakJul 29, 2015
  32. Karthik NayakJul 30, 2015
  33. 08/11 tag.c: use 'ref-filter' data structuresKarthik Nayak, Jul 27, 2015
  34. 09/11 tag.c: use 'ref-filter' APIsKarthik Nayak, Jul 27, 2015
  35. 10/11 tag.c: implement '--format' optionKarthik Nayak, Jul 27, 2015
  36. 11/11 tag.c: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jul 27, 2015
  37. Matthieu MoyJul 27, 2015
  38. Karthik NayakJul 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.