Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jul 27, 2015, 15:59 UTC
Message-ID: <CAOLa=ZT58Fai++91AUH2VcerH5OLkbC3thoGtqVYC70R8gSkaA@mail.gmail.com>
In-Reply-To: <CAOLa=ZSXD-pjgYCOt+ZcYS4uHS0p2uBYX8Rw80xpL+9pNUvm+w@mail.gmail.com>

On Mon, Jul 27, 2015 at 9:27 PM, Karthik Nayak <karthik.188@gmail.com> wrote:

Show 26 quoted lines

> On Mon, Jul 27, 2015 at 6:24 PM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>> --- a/ref-filter.c
>>> +++ b/ref-filter.c
>>> @@ -946,6 +946,32 @@ static int commit_contains(struct ref_filter *filter, struct commit *commit)
>>
>>> +/*
>>> + * Return 1 if the refname matches one of the patterns, otherwise 0.
>>>   * A pattern can be path prefix (e.g. a refname "refs/heads/master"
>>>   * matches a pattern "refs/heads/") or a wildcard (e.g. the same ref
>>>   * matches "refs/heads/m*",too).
>>
>> Nit: you used to s/,too/, too/ in the comment in a previous version.
>>
>
> That's carried over from a previous patch, ill change it.
>
>> I think I already suggested saying explicitly "... matches a pattern
>> "refs/heads/" but not "refs/heads/m")", but I won't insist on that. Just
>> a reminder in case you missed it.
>>
>
> Sorry, I missed that out. Thanks for reminding.
>

If I remember right, I didn't change that cause It didn't pertain to this commit. I forgot to mention it in your previous mail.

-- 
Regards,
Karthik Nayak