git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 3/9] log, format-patch: parsing uses OPT__QUIET

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 31, 2013, 17:08 UTC
Message-ID
<CAPig+cSazYJDP40zqkr47iuJ925bH-eFEjp2kzb_D3efgqggNw@mail.gmail.com>
In-Reply-To
<1375288117-1576-4-git-send-email-stefanbeller@googlemail.com>

On Wed, Jul 31, 2013 at 12:28 PM, Stefan Beller <stefanbeller@googlemail.com> wrote:

> This patch allows users to use the short form -q on
> log and format-patch, which was non possible before.
It would make sense for documentation updates to accompany these changes.
Show 35 quoted lines
> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
> ---
>  builtin/log.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/builtin/log.c b/builtin/log.c
> index 1dafbd0..ed4dec4 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -121,7 +121,7 @@ static void cmd_log_init_finish(int argc, const char **argv, const char *prefix,
>         static struct line_opt_callback_data line_cb = {NULL, NULL, STRING_LIST_INIT_DUP};
>
>         const struct option builtin_log_options[] = {
> -               OPT_BOOL(0, "quiet", &quiet, N_("suppress diff output")),
> +               OPT__QUIET(&quiet, N_("suppress diff output")),
>                 OPT_BOOL(0, "source", &source, N_("show source")),
>                 OPT_BOOL(0, "use-mailmap", &mailmap, N_("Use mail map file")),
>                 { OPTION_CALLBACK, 0, "decorate", NULL, NULL, N_("decorate options"),
> @@ -1210,8 +1210,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
>                             PARSE_OPT_OPTARG, thread_callback },
>                 OPT_STRING(0, "signature", &signature, N_("signature"),
>                             N_("add a signature")),
> -               OPT_BOOLEAN(0, "quiet", &quiet,
> -                           N_("don't print the patch filenames")),
> +               OPT__QUIET(&quiet, N_("don't print the patch filenames")),
>                 OPT_END()
>         };
>
> --
> 1.8.4.rc0.1.g8f6a3e5
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous: Stefan BellerNext: Stefan Beller
Message 5 of 14 in “[PATCHv2 0/9] Removing deprecated parsing macros”
  1. Stefan BellerJul 31, 2013
  2. 1/9 Remove deprecated OPTION_BOOLEAN for parsing argumentsStefan Beller, Jul 31, 2013
  3. 2/9 Replace deprecated OPT_BOOLEAN by OPT_BOOLStefan Beller, Jul 31, 2013
  4. 3/9 log, format-patch: parsing uses OPT__QUIETStefan Beller, Jul 31, 2013
  5. Eric SunshineJul 31, 2013
  6. 4/9 checkout: remove superfluous local variableStefan Beller, Jul 31, 2013
  7. 5/9 branch, commit, name-rev: ease up boolean conditionsStefan Beller, Jul 31, 2013
  8. 6/9 hash-object: Replace stdin parsing OPT_BOOLEAN by OPT_COUNTUPStefan Beller, Jul 31, 2013
  9. Eric SunshineJul 31, 2013
  10. 7/9 config: parsing options: config file flag multiple timesStefan Beller, Jul 31, 2013
  11. 8/9 checkout-index: Fix negations of even numbers of -nStefan Beller, Jul 31, 2013
  12. Eric SunshineJul 31, 2013
  13. Eric SunshineJul 31, 2013
  14. 9/9 revert: use the OPT_CMDMODE for parsing, reducing codeStefan Beller, Jul 31, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.