git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 6/9] hash-object: Replace stdin parsing OPT_BOOLEAN by OPT_COUNTUP

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 31, 2013, 17:12 UTC
Message-ID
<CAPig+cSHmZcov5NRxkvRhdqB0XB72LW+K04f4ayfMq2VZrb8CA@mail.gmail.com>
In-Reply-To
<1375288117-1576-7-git-send-email-stefanbeller@googlemail.com>

On Wed, Jul 31, 2013 at 12:28 PM, Stefan Beller <stefanbeller@googlemail.com> wrote:

Show 12 quoted lines
> This task emerged from b04ba2bb (parse-options: deprecate OPT_BOOLEAN,
> 2011-09-27). hash-object is a plumbing layer command, so better
> not change the input/output behavior for now.
>
> Unfortunately we have these lines relying on the count up mechanism of
> OPT_BOOLEAN:
>
>         if (hashstdin > 1)
>                 errstr = "Multiple --stdin arguments are not supported";
>
> Maybe later, when the plumbing is refined (git 2.0?) we can drop that
> errormessage and replace the OPT_COUNTUP by OPT_BOOL.
s/errormessage/error message/
> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
Previous: Stefan BellerNext: Stefan Beller
Message 9 of 14 in “[PATCHv2 0/9] Removing deprecated parsing macros”
  1. Stefan BellerJul 31, 2013
  2. 1/9 Remove deprecated OPTION_BOOLEAN for parsing argumentsStefan Beller, Jul 31, 2013
  3. 2/9 Replace deprecated OPT_BOOLEAN by OPT_BOOLStefan Beller, Jul 31, 2013
  4. 3/9 log, format-patch: parsing uses OPT__QUIETStefan Beller, Jul 31, 2013
  5. Eric SunshineJul 31, 2013
  6. 4/9 checkout: remove superfluous local variableStefan Beller, Jul 31, 2013
  7. 5/9 branch, commit, name-rev: ease up boolean conditionsStefan Beller, Jul 31, 2013
  8. 6/9 hash-object: Replace stdin parsing OPT_BOOLEAN by OPT_COUNTUPStefan Beller, Jul 31, 2013
  9. Eric SunshineJul 31, 2013
  10. 7/9 config: parsing options: config file flag multiple timesStefan Beller, Jul 31, 2013
  11. 8/9 checkout-index: Fix negations of even numbers of -nStefan Beller, Jul 31, 2013
  12. Eric SunshineJul 31, 2013
  13. Eric SunshineJul 31, 2013
  14. 9/9 revert: use the OPT_CMDMODE for parsing, reducing codeStefan Beller, Jul 31, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.