Re: [PATCH 2/5] Make git-log honor log.merges option

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 22, 2015, 20:50 UTC
Message-ID: <CAPig+cSOc-V=DG=tq7q8sWjJjMpnx8vNkGk56eFFWCMU-u77Rg@mail.gmail.com>
In-Reply-To: <1427048921-28677-2-git-send-email-koosha@posteo.de>

On Sun, Mar 22, 2015 at 2:28 PM, Koosha Khajehmoogahi <koosha@posteo.de> wrote:

> Subject: Make git-log honor log.merges option

Drop capitalization, mention area you're touching, followed by colon, followed by short summary:

    log: honor log.merges option

> Signed-off-by: Koosha Khajehmoogahi <koosha@posteo.de>

As discussed in my review of patch 1/5, since Junio actually wrote this patch[1], it would be more correct and considerate to attribute it to him by ensuring that a "From:" header is at the very top of the commit message before mailing out the patch:

    From: Junio C Hamano <gitster@pobox.com>

(If Junio had also signed-off on his patch, you would also include his sign-off just above yours. In this case, he didn't sign off[1], so your sign-off is all that is needed; and Junio will add his own if he picks up this series.)

[1]: http://article.gmane.org/gmane.comp.version-control.git/265597

Show 34 quoted lines

> ---
> diff --git a/builtin/log.c b/builtin/log.c
> index dd8f3fc..c7a7aad 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -36,6 +36,7 @@ static int decoration_given;
>  static int use_mailmap_config;
>  static const char *fmt_patch_subject_prefix = "PATCH";
>  static const char *fmt_pretty;
> +static const char *log_merges;
>
>  static const char * const builtin_log_usage[] = {
>         N_("git log [<options>] [<revision range>] [[--] <path>...]"),
> @@ -386,6 +387,9 @@ static int git_log_config(const char *var, const char *value, void *cb)
>                         decoration_style = 0; /* maybe warn? */
>                 return 0;
>         }
> +       if (!strcmp(var, "log.merges")) {
> +               return git_config_string(&log_merges, var, value);
> +       }
>         if (!strcmp(var, "log.showroot")) {
>                 default_show_root = git_config_bool(var, value);
>                 return 0;
> @@ -628,6 +632,8 @@ int cmd_log(int argc, const char **argv, const char *prefix)
>
>         init_revisions(&rev, prefix);
>         rev.always_show_header = 1;
> +       if (log_merges && parse_merges_opt(&rev, log_merges))
> +               die("unknown config value for log.merges: %s", log_merges);
>         memset(&opt, 0, sizeof(opt));
>         opt.def = "HEAD";
>         opt.revarg_opt = REVARG_COMMITTISH;
> --
> 2.3.3.263.g095251d.dirty