git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] Add a new option 'merges' to revision.c

From
KKKoosha Khajehmoogahi <koosha@posteo.de>
Date
Mar 22, 2015, 18:28 UTC
Message-ID
<1427048921-28677-1-git-send-email-koosha@posteo.de>

revision.c: add a new option 'merges' with possible values of 'only', 'show' and 'hide'. The option is used when showing the list of commits. The value 'only' lists only merges. The value 'show' is the default behavior which shows the commits as well as merges and the value 'hide' makes it just list commit items.

Signed-off-by: Koosha Khajehmoogahi <koosha@posteo.de>
---
 revision.c | 22 ++++++++++++++++++++++
 revision.h |  1 +
 2 files changed, 23 insertions(+)
diff --git a/revision.c b/revision.c
index 66520c6..edb7bed 100644
--- a/revision.c
+++ b/revision.c
@@ -1678,6 +1678,23 @@ static void add_message_grep(struct rev_info *revs, const char *pattern)
 	add_grep(revs, pattern, GREP_PATTERN_BODY);
 }
 
+int parse_merges_opt(struct rev_info *revs, const char *param)
+{
+	if (!strcmp(param, "show")) {
+		revs->min_parents = 0;
+		revs->max_parents = -1;
+	} else if (!strcmp(param, "only")) {
+		revs->min_parents = 2;
+		revs->max_parents = -1;
+	} else if (!strcmp(param, "hide")) {
+		revs->min_parents = 0;
+		revs->max_parents = 1;
+	} else {
+		return -1;
+	}
+	return 0;
+}
+
 static int handle_revision_opt(struct rev_info *revs, int argc, const char **argv,
 			       int *unkc, const char **unkv)
 {
@@ -1800,9 +1817,14 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg
 		revs->show_all = 1;
 	} else if (!strcmp(arg, "--remove-empty")) {
 		revs->remove_empty_trees = 1;
+	} else if (starts_with(arg, "--merges=")) {
+		if (parse_merges_opt(revs, arg + 9))
+			die("unknown option: %s", arg);
 	} else if (!strcmp(arg, "--merges")) {
+		revs->max_parents = -1;
 		revs->min_parents = 2;
 	} else if (!strcmp(arg, "--no-merges")) {
+		revs->min_parents = 0;
 		revs->max_parents = 1;
 	} else if (starts_with(arg, "--min-parents=")) {
 		revs->min_parents = atoi(arg+14);
diff --git a/revision.h b/revision.h
index 0ea8b4e..f9df58c 100644
--- a/revision.h
+++ b/revision.h
@@ -240,6 +240,7 @@ extern int setup_revisions(int argc, const char **argv, struct rev_info *revs,
 extern void parse_revision_opt(struct rev_info *revs, struct parse_opt_ctx_t *ctx,
 			       const struct option *options,
 			       const char * const usagestr[]);
+extern int parse_merges_opt(struct rev_info *, const char *);
 #define REVARG_CANNOT_BE_FILENAME 01
 #define REVARG_COMMITTISH 02
 extern int handle_revision_arg(const char *arg, struct rev_info *revs,
-- 
2.3.3.263.g095251d.dirty
Next: Koosha Khajehmoogahi
Message 1 of 20 in “Add a new option 'merges' to revision.c”
  1. 1/5 Add a new option 'merges' to revision.cKoosha Khajehmoogahi, Mar 22, 2015
  2. 2/5 Make git-log honor log.merges optionKoosha Khajehmoogahi, Mar 22, 2015
  3. Eric SunshineMar 22, 2015
  4. 3/5 Update documentations for git-log to include the new --merges option and also its corresponding config option.Koosha Khajehmoogahi, Mar 22, 2015
  5. Eric SunshineMar 22, 2015
  6. 4/5 Add tests for git-log --merges=show|hide|onlyKoosha Khajehmoogahi, Mar 22, 2015
  7. Torsten BögershausenMar 22, 2015
  8. Eric SunshineMar 22, 2015
  9. Koosha KhajehmoogahiMar 22, 2015
  10. Eric SunshineMar 22, 2015
  11. Koosha KhajehmoogahiMar 22, 2015
  12. Torsten BögershausenMar 23, 2015
  13. Eric SunshineMar 22, 2015
  14. 5/5 Update Bash completion script to include git log --merges optionKoosha Khajehmoogahi, Mar 22, 2015
  15. Eric SunshineMar 22, 2015
  16. SZEDER GáborMar 23, 2015
  17. Eric SunshineMar 22, 2015
  18. Junio C HamanoMar 22, 2015
  19. Koosha KhajehmoogahiMar 23, 2015
  20. Junio C HamanoMar 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.