git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] push: improve consistency of output when "up to date"

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jan 12, 2024, 03:14 UTC
Message-ID
<CAPig+cSO74EbK7RS5t3TAbRLUuLyynenugg4RgsOQ_=VyA4aAw@mail.gmail.com>
In-Reply-To
<xmqqjzofec0e.fsf@gitster.g>
On Thu, Jan 11, 2024 at 5:33 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
> > Thanks. This particular change is proposed periodically...
> > ... but has not been considered desirable.
> >
> > See, for instance, this email thread explaining the rationale for
> > avoiding such a change:
> > https://lore.kernel.org/git/pull.1298.git.1658908927714.gitgitgadget@gmail.com/T/
>
> Let's do the second best thing, leave a short comment near them, to
> make it possible for those who are motivated enough to find out why
> we decided to tell them "do not modify".
> ---
> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> @@ -333,6 +333,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
>         if (!ret && !transport_refs_pushed(remote_refs))
> +               /* do not modify this string */
>                 fprintf(stderr, "Everything up-to-date\n");

Yes, that helps, though, we can probably be a bit more friendly to future developers. Rather than insisting that they dig through history, we could use a slightly less terse comment, such as:

    /* stable plumbing output; do not modify or localize */
Previous: Junio C HamanoNext: Eric Sunshine
Message 4 of 11 in “push: improve consistency of output when "up to date"”
  1. push: improve consistency of output when "up to date"Benji Kay via GitGitGadget, Jan 11, 2024
  2. Eric SunshineJan 11, 2024
  3. Junio C HamanoJan 11, 2024
  4. Eric SunshineJan 12, 2024
  5. messages: mark some strings with "up-to-date" not to touchEric Sunshine, Jan 12, 2024
  6. Junio C HamanoJan 12, 2024
  7. Patrick SteinhardtJan 15, 2024
  8. Taylor BlauJan 11, 2024
  9. Eric SunshineJan 11, 2024
  10. Dragan SimicJan 17, 2024
  11. Benji KayJan 12, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.