Re: [PATCH] push: improve consistency of output when "up to date"

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 11, 2024, 21:43 UTC
Message-ID: <CAPig+cRr0V2ecnmxk1H_yF24dwSFA6niPxYXGH0MZ+wGP9m9UA@mail.gmail.com>
In-Reply-To: <pull.1638.git.1705008449995.gitgitgadget@gmail.com>

On Thu, Jan 11, 2024 at 4:27 PM Benji Kay via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 6 quoted lines

> When one issues the pull command, one may see "Already up to date."
> When issuing the push command, one may have seen "Everything up-to-date".
> To improve consistency, "Everything up to date." is printed instead.
> (The hyphens have been removed, and a period has been added.)
>
> Signed-off-by: okaybenji <okaybenji@gmail.com>

Thanks. This particular change is proposed periodically...

Show 5 quoted lines

> diff --git a/transport.c b/transport.c
> @@ -1467,7 +1467,7 @@ int transport_push(struct repository *r,
>         else if (!quiet && !ret && !transport_refs_pushed(remote_refs))
> -               fprintf(stderr, "Everything up-to-date\n");
> +               fprintf(stderr, "Everything up to date.\n");

... but has not been considered desirable.

See, for instance, this email thread explaining the rationale for avoiding such a change: https://lore.kernel.org/git/pull.1298.git.1658908927714.gitgitgadget@gmail.com/T/