git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 0/8] [Newcomer] t7004: modernize the style

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 13, 2024, 19:57 UTC
Message-ID
<CAPig+cSLzNyik6x2FQo6T4fAtTAsH07=y3g=MTXcSTvR7S2Vqg@mail.gmail.com>
In-Reply-To
<20240808163302.17521-1-abdobngad@gmail.com>
On Thu, Aug 8, 2024 at 12:34 PM AbdAlRahman Gad <abdobngad@gmail.com> wrote:
Show 7 quoted lines
> - Remove whitespace after the redirect operators.
>
> - Move number of expect files prepared outside of
>   test_expect_success to be inside the tests that use it.
> [...]
> There are still tests that could lose exit status to pipe. This needs
> to be modernized too, I will fix them in another patch series.

Thanks. This sort of information -- explaining the aim of the series and explaining what will be done later -- is appreciated by reviewers.

There are a few additional pieces of information you can include in the cover letter to make life even simpler for reviewers:

* provide a link to the previous version of the series
* explain what differs in this version as compared with the previous version
* include a range-diff showing the actual changes between this version
and the previous version (see `git format-patch --range-diff=`

There are many good examples on the mailing which illustrate the above points; here is one such instance: https://lore.kernel.org/git/20240726081522.28015-1-ericsunshine@charter.net/

Previous: AbdAlRahman GadNext: AbdAlRahman Gad
Message 10 of 11 in “[Newcomer] t7004: modernize the style”
  1. 0/8 [Newcomer] t7004: modernize the styleAbdAlRahman Gad, Aug 8, 2024
  2. 1/8 t7004: remove space after redirect operatorsAbdAlRahman Gad, Aug 8, 2024
  3. 2/8 t7004: one command per lineAbdAlRahman Gad, Aug 8, 2024
  4. 3/8 t7004: do not prepare things outside test_expect_successAbdAlRahman Gad, Aug 8, 2024
  5. 4/8 t7004: use indented here-docAbdAlRahman Gad, Aug 8, 2024
  6. 5/8 t7004: description on the same line as test_expect_successAbdAlRahman Gad, Aug 8, 2024
  7. 6/8 t7004: begin the test body on the same line as test_expect_successAbdAlRahman Gad, Aug 8, 2024
  8. 7/8 t7004: use single quotes instead of double quotesAbdAlRahman Gad, Aug 8, 2024
  9. 8/8 t7004: make use of write_scriptAbdAlRahman Gad, Aug 8, 2024
  10. Eric SunshineAug 13, 2024
  11. AbdAlRahman GadAug 13, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.