git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 0/8] [Newcomer] t7004: modernize the style

From
AbdAlRahman Gad <abdobngad@gmail.com>
Date
Aug 8, 2024, 16:31 UTC
Message-ID
<20240808163302.17521-1-abdobngad@gmail.com>
- Remove whitespace after the redirect operators.
- Move number of expect files prepared outside of
  test_expect_success to be inside the tests that use it.
- Split some lines that have two commands into two lines
  one command each.
- Turn some "<<\EOF" into "<<-\EOF" and indent their body.
- Avoid using pipes in the output from "test-tool ref-store"
  and write the output to a file.
- Change test_expect_success that are seperated from its name
  to be on the same line.
- Avoid separating test Description and test body with backslash
- Use single quotes instead of double quotes for test description and
  body.
- Use write_script which takes care of emitting the `#!/bin/sh` line
  and the `chmod +x`.

There are still tests that could lose exit status to pipe. This needs to be modernized too, I will fix them in another patch series.

AbdAlRahman Gad (8):
  t7004: remove space after redirect operators
  t7004: one command per line
  t7004: do not prepare things outside test_expect_success
  t7004: use indented here-doc
  t7004: description on the same line as test_expect_success
  t7004: begin the test body on the same line as test_expect_success
  t7004: use single quotes instead of double quotes
  t7004: make use of write_script
 t/t7004-tag.sh | 1144 +++++++++++++++++++++++-------------------------
 1 file changed, 549 insertions(+), 595 deletions(-)
base-commit: 406f326d271e0bacecdb00425422c5fa3f314930
-- 
2.43.0
Next: AbdAlRahman Gad
Message 1 of 11 in “[Newcomer] t7004: modernize the style”
  1. 0/8 [Newcomer] t7004: modernize the styleAbdAlRahman Gad, Aug 8, 2024
  2. 1/8 t7004: remove space after redirect operatorsAbdAlRahman Gad, Aug 8, 2024
  3. 2/8 t7004: one command per lineAbdAlRahman Gad, Aug 8, 2024
  4. 3/8 t7004: do not prepare things outside test_expect_successAbdAlRahman Gad, Aug 8, 2024
  5. 4/8 t7004: use indented here-docAbdAlRahman Gad, Aug 8, 2024
  6. 5/8 t7004: description on the same line as test_expect_successAbdAlRahman Gad, Aug 8, 2024
  7. 6/8 t7004: begin the test body on the same line as test_expect_successAbdAlRahman Gad, Aug 8, 2024
  8. 7/8 t7004: use single quotes instead of double quotesAbdAlRahman Gad, Aug 8, 2024
  9. 8/8 t7004: make use of write_scriptAbdAlRahman Gad, Aug 8, 2024
  10. Eric SunshineAug 13, 2024
  11. AbdAlRahman GadAug 13, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.