Re: [PATCH v3] teach fast-export an --anonymize option

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 31, 2014, 10:34 UTC
Message-ID: <CAPig+cSKfxAsr+RQp8N8GAOe9fa_6kGPi_-X99Vs-2bYbBoC8A@mail.gmail.com>
In-Reply-To: <20140828123257.GA18642@peff.net>

On Thu, Aug 28, 2014 at 8:32 AM, Jeff King <peff@peff.net> wrote:

Show 21 quoted lines

> On Thu, Aug 28, 2014 at 05:30:44PM +0700, Duy Nguyen wrote:
>
>> On Thu, Aug 28, 2014 at 12:01 AM, Jeff King <peff@peff.net> wrote:
>> > You can get an overview of what will be shared
>> > by running a command like:
>> >
>> >   git fast-export --anonymize --all |
>> >   perl -pe 's/\d+/X/g' |
>> >   sort -u |
>> >   less
>> >
>> > which will show every unique line we generate, modulo any
>> > numbers (each anonymized token is assigned a number, like
>> > "User 0", and we replace it consistently in the output).
>>
>> I feel like this should be part of git-fast-export.txt, just to
>> increase the user's confidence in the tool (and I don't expect most
>> users to read this commit message).
>
> Hmph. Whenever I say "I think this patch is done", suddenly the comments
> start pouring in. :)

Considering that the value of --anonymize is not yet known, is such an invasive change to fast-export.c warranted? Would it make sense instead to provide "anonymize" functionality as a contrib/ script or a distinct git-anonymize-foo command which accepts a fast-import stream as input and anonymizes it as output?