Re: [PATCH v2] push: respect --no-thin

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 11, 2013, 05:12 UTC
Message-ID: <CAPig+cSEUrKBg4e9Q+hdeJ1P=3ANwPJfZO6bohH79ZxxuO-PcQ@mail.gmail.com>
In-Reply-To: <1376184258-6784-1-git-send-email-pclouds@gmail.com>

On Sat, Aug 10, 2013 at 9:24 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 19 quoted lines

> Over the time the default value for --thin has been switched between
> on and off. As of now it's always on, even if --no-thin is given.
> Correct the code to respect --no-thin.
>
> receive-pack learns about --no-thin only for testing purposes, hence
> no document update.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
> index 4691d51..e80247b 100755
> --- a/t/t5516-fetch-push.sh
> +++ b/t/t5516-fetch-push.sh
> @@ -1172,4 +1172,16 @@ test_expect_success 'push --follow-tag only pushes relevant tags' '
>         test_cmp expect actual
>  '
>
> +test_expect_success 'push --no-thin must produce non-thin pack' '
> +       for i in `seq 100`; do echo modified >> path1; done &&

s/seq/test_seq/

d17cf5f3a32f07bf (tests: Introduce test_seq;  2012-08-03)

Show 13 quoted lines

> +       git commit -am "path1 big enough to pass size heuristics in try_delta" &&
> +       git init no-thin &&
> +       git --git-dir=no-thin/.git config receive.unpacklimit 0 &&
> +       git push no-thin/.git refs/heads/master:refs/heads/foo &&
> +       echo modified >> path1 &&
> +       git commit -am modified &&
> +       git repack -adf &&
> +       git push --no-thin --receive-pack="git receive-pack --no-thin" no-thin/.git refs/heads/master:refs/heads/foo
> +'
> +
>  test_done
> --
> 1.8.2.83.gc99314b