Re: [PATCH] push: respect --no-thin
- From
Jeff King <peff@peff.net>
- Date
- Aug 10, 2013, 10:31 UTC
- Message-ID
- <20130810103123.GB6237@sigill.intra.peff.net>
- In-Reply-To
- <1376129407-30590-1-git-send-email-pclouds@gmail.com>
On Sat, Aug 10, 2013 at 05:10:07PM +0700, Nguyen Thai Ngoc Duy wrote:
Show 5 quoted lines
> Over the time the default value for --thin has been switched between > on and off. As of now it's always on, even if --no-thin is given. > Correct the code to respect --no-thin. > > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
This makes sense, and I confirmed with the script I posted earlier that it does work (and didn't before). Thanks.
It might be nice to have a test, but I am not sure of a good way to check whether a push was thin. I guess we can grep the output of GIT_TRACE, though it feels a bit hacky.
-Peff