Re: [PATCH 4/8] Doc/gitsubmodules: avoid abbreviations

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 7, 2018, 00:36 UTC
Message-ID: <CAPig+cS2PAGm1OfQLOv+MOOvbUnFOUtfzXLOFfVNAD_VOhfntQ@mail.gmail.com>
In-Reply-To: <20180106184614.20115-5-kaartic.sivaraam@gmail.com>

On Sat, Jan 6, 2018 at 1:46 PM, Kaartic Sivaraam <kaartic.sivaraam@gmail.com> wrote:

Show 10 quoted lines

> Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
> ---
> diff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt
> @@ -76,9 +76,9 @@ The configuration of submodules
> - * The command line for those commands that support taking submodule specs.
> -   Most commands have a boolean flag '--recurse-submodules' whether to
> -   recurse into submodules. Examples are `ls-files` or `checkout`.
> + * The command line for those commands that support taking submodule
> +   specifications. Most commands have a boolean flag '--recurse-submodules
> +   whether to recurse into submodules. Examples are `ls-files` or `checkout`.

Your change loses the closing quote on --recurse-submodules.

Also, since you're touching this, it wouldn't hurt to address the grammatical shortcoming(s), as well. To wit: Something is missing between "--recurse-submodules" and "whether".