Re: [PATCH] worktree: add --quiet option

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 7, 2018, 19:12 UTC
Message-ID: <CAPig+cS-b2yL2FeLRzS+jW-O5fRd1g8Kqak7j1QX5PRP0ojQEQ@mail.gmail.com>
In-Reply-To: <20180807132113.118297-1-gitter.spiros@gmail.com>

(cc:+Karen Arutyunov[1]; perhaps also do so when you re-roll)

In addition to the good review comments by Martin and Duy...

On Tue, Aug 7, 2018 at 9:21 AM Elia Pinto <gitter.spiros@gmail.com> wrote:

> Add the '--quiet' option to git worktree add,
> as for the other git commands.

It might make sense to say instead that this is adding a --quiet option _in general_, rather than doing so specifically for 'add'. Then, go on to say that, at present, 'add' is the only command affected by it since all other commands are currently silent by default (except, of course, 'list').

Whether you like that idea or not, as Martin suggested, please do say something in the commit message about why the other commands don't need it.

Show 12 quoted lines

> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
> diff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt
> @@ -115,7 +115,9 @@ Unlock a working tree, allowing it to be pruned, moved or deleted.
>  OPTIONS
>  -------
> -
> +-q::
> +--quiet::
> +       With 'add', suppress feedback messages.
>  -f::
>  --force::

In addition to the blank-line issues Martin raised, please move this hunk downward to be a neighbor of the --verbose option.

REFERENCES [1]: https://public-inbox.org/git/02659385-334f-2b77-c9a8-ffea8e461b0b@codesynthesis.com/