Re: [PATCH] remote: add meaningful exit code on missing/existing

From

Eric Sunshine <sunshine@sunshineco.com>

Date

Oct 26, 2020, 14:52 UTC

Message-ID

<CAPig+cRvCPaUxoCojiHvwte4Ty9iRmOaYGrcKs7WHXQN=bid6g@mail.gmail.com>

In-Reply-To

<20201026144825.26537-1-avarab@gmail.com>

> Change the exit code for the likes of "git remote add/rename" to exit
> with 2 if the remote in question doesn't exist, and 3 if it
> does. Before we'd just die() and exit with the general 128 exit code.
> [...]
> So e.g. if a sleep() is added right after the remote_is_configured()
> check in add() we'll clobber rermote.NAME.url, and add

s/rermote/remote/

> another (usually duplicate) remote.NAME.fetch entry (and other values,
> depending on invocation).
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>