Re: [PATCH] remote: add meaningful exit code on missing/existing

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Oct 26, 2020, 19:55 UTC
Message-ID: <CAKPyHN0Dbk+fqYR-5-RMUanJXFqjzh_w6zd0QXnM1fMpSUDJ3Q@mail.gmail.com>
In-Reply-To: <20201026144825.26537-1-avarab@gmail.com>

On Mon, Oct 26, 2020 at 3:48 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 14 quoted lines

> diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt
> index 9659abbf8e..c1f1355f52 100644
> --- a/Documentation/git-remote.txt
> +++ b/Documentation/git-remote.txt
> @@ -203,6 +203,17 @@ The remote configuration is achieved using the `remote.origin.url` and
>  `remote.origin.fetch` configuration variables.  (See
>  linkgit:git-config[1]).
>
> +EXIT STATUS
> +-----------
> +
> +On success, the exit status is `0`.
> +
> +When subcommands such as 'add', 'rename' and 'remove' can't find the

at least a comma before 'and', but I consider 'or' better here anyway:

When subcommands such as 'add', 'rename', or 'remove' can't find the

Bert

Show 8 quoted lines

> +remote in question the exit status is `2`, when the remote already
> +exists the exit status is `3`.
> +
> +On any other error, the exit status may be any other non-zero value.
> +
>  EXAMPLES
>  --------
>