Re: [PATCH 1/2] Document git config getter return value.

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 1, 2018, 08:24 UTC
Message-ID: <CAPig+cRv5sHSoAPVi=Dnu2HXcbGThdMsgOfvs-Kh2NbnGg-j8w@mail.gmail.com>
In-Reply-To: <20180731173651.184716-2-hanwen@google.com>

On Tue, Jul 31, 2018 at 1:37 PM Han-Wen Nienhuys <hanwen@google.com> wrote:

Show 6 quoted lines

> diff --git a/config.h b/config.h
> @@ -178,10 +178,16 @@ struct config_set {
> +/*
> + * The int return values in the functions is 1 if not found, 0 if found, leaving
> + * the found value in teh 'dest' pointer.
> + */

"teh"?

Instead of talking about "the int return values", simpler would be to say "returns 1 if ...; else 0". Not worth a re-roll, though.

> +extern int git_configset_add_file(struct config_set *cs, const char *filename);
> +extern int git_configset_get_value(struct config_set *cs, const char *key, const char **dest);