git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Highlight keywords in remote sideband output.

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Aug 2, 2018, 11:46 UTC
Message-ID
<CAFQ2z_NOxB4E13hoUPwoP+kZ0rVofCf3mb+bdopyTLnzWu1kPA@mail.gmail.com>
In-Reply-To
<CAPig+cR3WdYpZftK72MKMs4BBF2ZiuO-Bm_-edJ4tr1bRQvoGQ@mail.gmail.com>
On Thu, Aug 2, 2018 at 12:24 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 21 quoted lines
>
> On Wed, Aug 1, 2018 at 2:17 PM Junio C Hamano <gitster@pobox.com> wrote:
> > Han-Wen Nienhuys <hanwen@google.com> writes:
> > > Sorry for being dense, but do you want me to send an updated patch or
> > > not based on your and Eric's comments or not?
> >
> > It would help to see the comments responded with either "such a
> > change is not needed for such and such reasons", "it may make sense
> > but let's leave it to a follow-up patch later," etc., or with a
> > "here is an updated patch, taking all the comments to the previous
> > version into account---note that I rejected that particular comment
> > because of such and such reasons".
>
> Right. The way to know whether or not an updated patch is warranted is
> to respond to review comments, saying that you agree or disagree with
> various points raised (and why), and by answering the (genuine)
> questions raised during review. The outcome of the dialogue with
> reviewers will make it clear if an updated patch is necessary. (It's
> also a courtesy to respond to review comments since reviewing is
> time-consuming business and it's good to let reviewers know that the
> time spent reviewing was not in vain.)

Sure. My doubt is that it's hard to tell what the state of my patch is at any given time.

--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Previous: Eric SunshineNext: Eric Sunshine
Message 12 of 15 in “Highlight keywords in remote sideband output.”
  1. 0/2 Highlight keywords in remote sideband output.Han-Wen Nienhuys, Jul 31, 2018
  2. 1/2 Document git config getter return value.Han-Wen Nienhuys, Jul 31, 2018
  3. Eric SunshineAug 1, 2018
  4. 2/2 Highlight keywords in remote sideband output.Han-Wen Nienhuys, Jul 31, 2018
  5. Junio C HamanoJul 31, 2018
  6. Eric SunshineJul 31, 2018
  7. Junio C HamanoAug 1, 2018
  8. Han-Wen NienhuysAug 1, 2018
  9. Junio C HamanoAug 1, 2018
  10. Han-Wen NienhuysAug 2, 2018
  11. Eric SunshineAug 2, 2018
  12. Han-Wen NienhuysAug 2, 2018
  13. Eric SunshineAug 2, 2018
  14. Stefan BellerAug 2, 2018
  15. Han-Wen NienhuysAug 2, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.