git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Forgotten declaration of function path_name() in revision.h?

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 16, 2016, 18:52 UTC
Message-ID
<CAPig+cReEC1swN8oyD68SqHAJhV2i1_CGEO25sJfA-4gA7jP0w@mail.gmail.com>
In-Reply-To
<20160316184853.GA32615@sigill.intra.peff.net>
On Wed, Mar 16, 2016 at 2:48 PM, Jeff King <peff@peff.net> wrote:
Show 14 quoted lines
> It makes things easier on the maintainer if you format your patch such
> that "git am" can apply it directly. Use scissors like:
>
> -- >8 --
>
> to separate the patch from anything that should not go into the commit
> message (rather than "=====..." as you have here).
>
> Drop the "From " line which says nothing (it is an mbox separator, but
> we are already inside a message).
>
> The rest of the headers do not hurt, but are generally redundant with
> what is in your email header (though in this case, the Subject is
> different, so you would want to retain that).
Also, Signed-off-by: is missing.
Previous: Jeff KingNext: Petr Stodulka
Message 3 of 4 in “Forgotten declaration of function path_name() in revision.h?”
  1. Petr StodulkaMar 16, 2016
  2. Jeff KingMar 16, 2016
  3. Eric SunshineMar 16, 2016
  4. Petr StodulkaMar 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.