From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 16 Mar 2016 18:52:03 GMT
Subject: Re: Forgotten declaration of function path_name() in revision.h?
Message-ID: <CAPig+cReEC1swN8oyD68SqHAJhV2i1_CGEO25sJfA-4gA7jP0w@mail.gmail.com>
In-Reply-To: <20160316184853.GA32615@sigill.intra.peff.net>

On Wed, Mar 16, 2016 at 2:48 PM, Jeff King <peff@peff.net> wrote:
> It makes things easier on the maintainer if you format your patch such
> that "git am" can apply it directly. Use scissors like:
>
> -- >8 --
>
> to separate the patch from anything that should not go into the commit
> message (rather than "=====..." as you have here).
>
> Drop the "From " line which says nothing (it is an mbox separator, but
> we are already inside a message).
>
> The rest of the headers do not hurt, but are generally redundant with
> what is in your email header (though in this case, the Subject is
> different, so you would want to retain that).

Also, Signed-off-by: is missing.