Re: [PATCH v4 1/2] t0006: simplify prerequisites

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 25, 2024, 23:30 UTC
Message-ID: <CAPig+cRaQbWTLnvbx-Yec3mGEJDOQQr8RX+bT=J1FzVDqjq2_g@mail.gmail.com>
In-Reply-To: <20240625231248.4070257-2-gitster@pobox.com>

On Tue, Jun 25, 2024 at 7:13 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> The system must support 64-bit time and its time_t must be 64-bit
> wide to pass these tests.  Combine these two prerequisites together
> to simplify the tests.  In theory, they could be fulfilled
> independently and tests could require only one without the other,
> but in practice, but in practice these must come hand-in-hand.

s/but in practice, but in practice/but in practice/

Show 8 quoted lines

> Update the "check_parse" test helper to pay attention to the
> REQUIRE_64BIT_TIME variable, which can be set to the HAVE_64BIT_TIME
> prerequisite so that a parse test can be skipped on 32-bit systems.
> This will be used in the next step to skip tests for timestamps near
> the end of year 2099, as 32-bit systems will not be able to express
> a timestamp beyond 2038 anyway.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>