Re: [PATCH] linear-assignment: fix potential out of bounds memory access (was: Re: Git 2.19 Segmentation fault 11 on macOS)

From

Eric Sunshine <sunshine@sunshineco.com>

Date

Sep 13, 2018, 10:14 UTC

Message-ID

<CAPig+cRZm6iznBzBF1pwj1v12XX=Q_jzLxSLjWpEMja73r_juw@mail.gmail.com>

In-Reply-To

<20180912190108.GE4865@hank.intra.tgummerer.com>

On Wed, Sep 12, 2018 at 3:01 PM Thomas Gummerer <t.gummerer@gmail.com> wrote:

> Subject: [PATCH] linear-assignment: fix potential out of bounds memory access
>
> Currently the 'compute_assignment()' function can may read memory out

"can may"?

> of bounds, even if used correctly.  Namely this happens when we only
> have one column.  In that case we try to calculate the initial
> minimum cost using '!j1' as column in the reduction transfer code.
> That in turn causes us to try and get the cost from column 1 in the
> cost matrix, which does not exist, and thus results in an out of
> bounds memory read.