Re: [PATCH v2] linear-assignment: fix potential out of bounds memory access

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 17, 2018, 18:48 UTC
Message-ID: <20180917184838.GE140909@aiede.svl.corp.google.com>
In-Reply-To: <20180913223834.GF1719@hank.intra.tgummerer.com>

Thomas Gummerer wrote:

> Currently the 'compute_assignment()' function may read memory out
> of bounds, even if used correctly.  Namely this happens when we only
> have one column.

[...]

Show 7 quoted lines

> Reported-by: ryenus <ryenus@gmail.com>
> Helped-by: Derrick Stolee <stolee@gmail.com>
> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
> ---
>  linear-assignment.c   | 6 ++++++
>  t/t3206-range-diff.sh | 5 +++++
>  2 files changed, 11 insertions(+)

Here's a bit of a non-review, but hopefully it pokes others into doing a proper review.

I haven't carefully examined the checks you're adding here. Your goals seem to be right. I've been running with this patch since last Thursday, with no problems yet. Thanks for writing it.

Sincerely, Jonathan