git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] implemented strbuf_write_or_die()

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 2, 2014, 02:55 UTC
Message-ID
<CAPig+cRXSQkC6eG+TAZQoZ5kJNjuv9Rq5QYjpFbEqDSeuVWU3g@mail.gmail.com>
In-Reply-To
<CAPig+cR0gTeB1oUUPQ=W_wWGPMDaY4gkG7+531HT-ktnwn5L-Q@mail.gmail.com>
On Sat, Mar 1, 2014 at 9:47 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 12 quoted lines
> On Sat, Mar 1, 2014 at 7:18 PM, Faiz Kothari <faiz.off93@gmail.com> wrote:
>> Implementing this clearly distinguishes between writing a normal buffer
>> and writing a strbuf. Also, it provides an interface to write strbuf
>> directly without knowing the private members of strbuf, making strbuf
>> completely opaque. Also, makes the code more readable.
>
> These three sentences which justify the change should go above the
> "---" line so they are recorded in the project history for future
> readers to understand why the change was made. As for their actual
> value, the first and third sentences are nebulous; the second sentence
> may be suitable (although strbuf's buf and len are actually considered
> public, so the justification not be supportable).
...justification *may* not be...
Previous: Eric SunshineNext: Faiz Kothari
Message 7 of 23 in “implemented strbuf_write_or_die()”
  1. implemented strbuf_write_or_die()Faiz Kothari, Mar 1, 2014
  2. He SunMar 1, 2014
  3. implemented strbuf_write_or_die()Faiz Kothari, Mar 1, 2014
  4. Michael HaggertyMar 1, 2014
  5. implemented strbuf_write_or_die()Faiz Kothari, Mar 2, 2014
  6. Eric SunshineMar 2, 2014
  7. Eric SunshineMar 2, 2014
  8. 1/2 Introduce strbuf_write_or_die()Faiz Kothari, Mar 2, 2014
  9. 2/2 use strbuf_write_or_die()Faiz Kothari, Mar 2, 2014
  10. Eric SunshineMar 2, 2014
  11. Eric SunshineMar 2, 2014
  12. Eric SunshineMar 2, 2014
  13. Junio C HamanoMar 3, 2014
  14. Eric SunshineMar 3, 2014
  15. David KastrupMar 3, 2014
  16. Junio C HamanoMar 3, 2014
  17. Eric SunshineMar 3, 2014
  18. Michael HaggertyMar 4, 2014
  19. Faiz KothariMar 4, 2014
  20. Junio C HamanoMar 4, 2014
  21. Johannes SixtMar 1, 2014
  22. Junio C HamanoMar 3, 2014
  23. Fwd: [PATCH] implemented strbuf_write_or_die()Faiz Kothari, Mar 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.