From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 02 Mar 2014 02:55:52 GMT
Subject: Re: [PATCH v2] implemented strbuf_write_or_die()
Message-ID: <CAPig+cRXSQkC6eG+TAZQoZ5kJNjuv9Rq5QYjpFbEqDSeuVWU3g@mail.gmail.com>
In-Reply-To: <CAPig+cR0gTeB1oUUPQ=W_wWGPMDaY4gkG7+531HT-ktnwn5L-Q@mail.gmail.com>

On Sat, Mar 1, 2014 at 9:47 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sat, Mar 1, 2014 at 7:18 PM, Faiz Kothari <faiz.off93@gmail.com> wrote:
>> Implementing this clearly distinguishes between writing a normal buffer
>> and writing a strbuf. Also, it provides an interface to write strbuf
>> directly without knowing the private members of strbuf, making strbuf
>> completely opaque. Also, makes the code more readable.
>
> These three sentences which justify the change should go above the
> "---" line so they are recorded in the project history for future
> readers to understand why the change was made. As for their actual
> value, the first and third sentences are nebulous; the second sentence
> may be suitable (although strbuf's buf and len are actually considered
> public, so the justification not be supportable).

...justification *may* not be...