Re: [PATCH v2 6/9] Pass directory indicator to match_pathspec_item()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 24, 2014, 21:22 UTC
Message-ID: <CAPig+cRW5Fz62Qk22qiUo85jmqVK0Hvbb6v2GxK7V+wS+S8_qw@mail.gmail.com>
In-Reply-To: <1390570836-20394-7-git-send-email-pclouds@gmail.com>

On Fri, Jan 24, 2014 at 8:40 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 12 quoted lines

> diff --git a/t/t4010-diff-pathspec.sh b/t/t4010-diff-pathspec.sh
> index af5134b..167af53 100755
> --- a/t/t4010-diff-pathspec.sh
> +++ b/t/t4010-diff-pathspec.sh
> @@ -110,4 +110,21 @@ test_expect_success 'diff-tree -r with wildcard' '
>         test_cmp expected result
>  '
>
> +test_expect_success 'setup submodules' '
> +       test_tick &&
> +       git init submod &&
> +       ( cd submod && test_commit first; ) &&

Unnecessary semicolon might confuse the reader into thinking something unusual is going on here.

> +       git add submod &&
> +       git commit -m first &&
> +       ( cd submod && test_commit second; ) &&

Ditto.

Show 11 quoted lines

> +       git add submod &&
> +       git commit -m second
> +'
> +
> +test_expect_success 'diff-cache ignores trailing slash on submodule path' '
> +       git diff --name-only HEAD^ submod >expect &&
> +       git diff --name-only HEAD^ submod/ >actual &&
> +       test_cmp expect actual
> +'
> +
>  test_done