Re: [PATCH v2 6/9] Pass directory indicator to match_pathspec_item()

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 25, 2014, 04:24 UTC
Message-ID: <CACsJy8Aj8EnDD5Qk=VStpDXTAV-WOh_utmiY+qXGyCwoXpQHog@mail.gmail.com>
In-Reply-To: <CAPig+cRW5Fz62Qk22qiUo85jmqVK0Hvbb6v2GxK7V+wS+S8_qw@mail.gmail.com>

On Sat, Jan 25, 2014 at 4:22 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 11 quoted lines

> On Fri, Jan 24, 2014 at 8:40 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>> diff --git a/t/t4010-diff-pathspec.sh b/t/t4010-diff-pathspec.sh
>> index af5134b..167af53 100755
>> --- a/t/t4010-diff-pathspec.sh
>> +++ b/t/t4010-diff-pathspec.sh
>> @@ -110,4 +110,21 @@ test_expect_success 'diff-tree -r with wildcard' '
>>         test_cmp expected result
>>  '
>>
>> +test_expect_success 'setup submodules' '
>> +       test_tick &&

Also the test_tick here. I thought I would need to match SHA-1 but I did not and still forgot to take this line out.

Show 23 quoted lines

>> +       git init submod &&
>> +       ( cd submod && test_commit first; ) &&
>
> Unnecessary semicolon might confuse the reader into thinking something
> unusual is going on here.
>
>> +       git add submod &&
>> +       git commit -m first &&
>> +       ( cd submod && test_commit second; ) &&
>
> Ditto.
>
>> +       git add submod &&
>> +       git commit -m second
>> +'
>> +
>> +test_expect_success 'diff-cache ignores trailing slash on submodule path' '
>> +       git diff --name-only HEAD^ submod >expect &&
>> +       git diff --name-only HEAD^ submod/ >actual &&
>> +       test_cmp expect actual
>> +'
>> +
>>  test_done

-- 
Duy