Re: [PATCH 25/25] diff.c: mention completion above add_diff_options
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jun 11, 2023, 02:36 UTC
- Message-ID
- <CAPig+cRPrf0dQbGKDvKkTBAXVVLWX_YcGEvg6Mcwuwe3k7bLnQ@mail.gmail.com>
- In-Reply-To
- <93b6233f0dd89d36c0eec7a4768f8b7d22db755b.1686428485.git.gitgitgadget@gmail.com>
On Sat, Jun 10, 2023 at 4:24 PM Philippe Blain via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 14 quoted lines
> Add a comment on top of add_diff_options, where common diff options are > listed, mentioning __git_diff_common_options in the completion script, > in the hope that contributors update it when they add new diff flags. > > Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com> > --- > diff --git a/diff.c b/diff.c > @@ -5491,6 +5491,9 @@ static int diff_opt_rotate_to(const struct option *opt, const char *arg, int uns > return 0; > } > > +/* Consider adding new flags to __git_diff_common_options > + * in contrib/completion/git-completion.bash > + */
Style:
/*
* This is a multi-line
* comment.
*/