Re: [PATCH v2 19/25] completion: complete --patch-with-raw

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Jun 12, 2023, 22:57 UTC
Message-ID: <5cba334c-4d75-0dac-20c6-9e3def1f224a@gmail.com>
In-Reply-To: <xmqq4jnc8iie.fsf@gitster.g>

Hi Junio,

Le 2023-06-12 à 17:42, Junio C Hamano a écrit :

Show 16 quoted lines

> "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>>
>> Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
>> ---
>>  contrib/completion/git-completion.bash | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Everything else in the series looked OK, but I am not sure if we
> want to advertise this historical wart that has no practical
> advantage over using "-p --raw".  The only reason why we kept it is
> because we do not have to even think about how likely it will break
> ancient scripts if we removed it.
> 
> Thanks.

Yes, I tend to agree. I can drop this one in the next version.