Re: SQUASH convert: add tracing for 'working-tree-encoding' attribute

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 22, 2018, 19:37 UTC
Message-ID: <CAPig+cRMHmFuMxQmSeGoK9hhUVEVVVLQs0j10Lo8bE5t8-V9OA@mail.gmail.com>
In-Reply-To: <20180122180042.70101-1-lars.schneider@autodesk.com>

On Mon, Jan 22, 2018 at 1:00 PM,  <lars.schneider@autodesk.com> wrote:

Show 6 quoted lines

> diff --git a/convert.c b/convert.c
> @@ -1165,8 +1165,9 @@ static struct encoding *git_path_check_encoding(struct attr_check_item *check)
> -       enc = xcalloc(1, sizeof(struct convert_driver));
> -       enc->name = xstrdup_toupper(value);  /* aways use upper case names! */
> +       enc = xcalloc(1, sizeof(*enc));
> +       /* Aways use upper case names to simplify subsequent string comparison. */

s/Aways/Always/

https://public-inbox.org/git/20180121142222.GA10248@ruderich.org/

> +       enc->name = xstrdup_toupper(value);
>         *encoding_tail = enc;
>         encoding_tail = &(enc->next);