git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] git: treat "-C <treat>" as a no-op when <path> is empty

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 8, 2015, 04:38 UTC
Message-ID
<CAPig+cRDkoH-zmYhk9ag+Yiwg1h452hOpS2fx2H5xmu5KUNqiQ@mail.gmail.com>
In-Reply-To
<54FAD7D7.4030008@gmail.com>
On Sat, Mar 7, 2015 at 5:49 AM, karthik nayak <karthik.188@gmail.com> wrote:
Show 7 quoted lines
>> This iteration looks sensible, except that the Subject reads
>> strange.  Will queue with minor tweaks to the log message,
>> and perhaps with a fix to unreadable *(*argv)[1] that was
>> mentioned elsewhere.
>
> Hey could you tell me what seems strange, so I can improve on
> it the next time.

Junio means that you somehow botched the Subject: line when you copied the commit message I suggested into your new version of the patch. Instead of <path>, you wrote <treat>.

> Also "*(*argv)[1]" seems more readable to me, maybe more of a perspective?

I also had considered suggesting (*argv)[1][0] as more readable, but it is primarily personal taste, and I didn't want to bike-shed the issue.

Previous: karthik nayakNext: karthik nayak
Message 5 of 8 in “git: treat "-C <treat>" as a no-op when <path> is empty”
  1. git: treat "-C <treat>" as a no-op when <path> is emptyKarthik Nayak, Mar 6, 2015
  2. Junio C HamanoMar 7, 2015
  3. Eric SunshineMar 7, 2015
  4. karthik nayakMar 7, 2015
  5. Eric SunshineMar 8, 2015
  6. karthik nayakMar 8, 2015
  7. Junio C HamanoMar 8, 2015
  8. karthik nayakMar 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.