Re: [PATCH v4] git: treat "-C <treat>" as a no-op when <path> is empty

From: karthik nayak <karthik.188@gmail.com>
Date: Mar 7, 2015, 10:49 UTC
Message-ID: <54FAD7D7.4030008@gmail.com>
In-Reply-To: <CAPig+cTkC1Y1sWJLpG0iUHju3GOMnvOT-nsAU51GykeV2QB+vA@mail.gmail.com>

 > This iteration looks sensible, except that the Subject reads
 > strange.  Will queue with minor tweaks to the log message,
 > and perhaps with a fix to unreadable *(*argv)[1] that was
 > mentioned elsewhere.
 >
 > Thanks.

Hey could you tell me what seems strange, so I can improve on it the next time. Also "*(*argv)[1]" seems more readable to me, maybe more of a perspective?

Thanks

On 03/07/2015 07:49 AM, Eric Sunshine wrote:

Show 15 quoted lines

> On Fri, Mar 6, 2015 at 6:18 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> 'git -C ""' unhelpfully dies with error "Cannot change to ''",
>> whereas the shell treats `cd ""' as a no-op. Taking the shell's
>> behavior as a precedent, teach git to treat `-C ""' as a no-op, as
>> well.
>>
>> Test to check the no-op behaviour of "-C <path>" when <path> is
>> empty, written by Junio C Hamano.
>>
>> Helped-by: Junio C Hamano <gitster@pobox.com>
>> Helped-by: Eric Sunchine <sunshine@sunshineco.com>
>
> s/Sunchine/Sunshine/
>
>> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>

Sorry Eric for the genuine mistake.