git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 0/6] Move PGP verification out of verify-tag

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 22, 2016, 17:22 UTC
Message-ID
<CAPig+cR9i1a7pxOxV4QU2TnoJWKn4mHHVT2tG3+uRysw=sc6qQ@mail.gmail.com>
In-Reply-To
<1461336725-29915-1-git-send-email-santiago@nyu.edu>
On Fri, Apr 22, 2016 at 10:51 AM,  <santiago@nyu.edu> wrote:
Show 10 quoted lines
> This is a follow up of [1], [2], [3], [4], [5], [6], and [7].  patches 1/6,
> 2/6, and 3/6, are the same as the corresponding commits in pu.
>
> v8:
> Minor nits, I decided to quickly reroll to drop the extern qualifier in tag.c:
>   * Eric pointed out that we could block-scope the declaration of name and sha1
>     in b/verify-tag.c, for 4/6
>   * There was a typo in 6/6
>   * I dropped the extern qualifier in tag.c for 5/6 as suggested by Ramsay
>     Jones[8]

Thanks, this version seems to address the few minor review comments from v7. Regardless of the whitespace nit in patch 5/6, this series is still:

    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Previous: santiago@nyu.edu
Message 9 of 9 in “Move PGP verification out of verify-tag”
  1. 0/6 Move PGP verification out of verify-tagsantiago@nyu.edu, Apr 22, 2016
  2. 1/6 builtin/verify-tag.c: ignore SIGPIPE in gpg-interfacesantiago@nyu.edu, Apr 22, 2016
  3. 2/6 t7030: test verifying multiple tagssantiago@nyu.edu, Apr 22, 2016
  4. 3/6 verify-tag: update variable name and typesantiago@nyu.edu, Apr 22, 2016
  5. 4/6 verify-tag: prepare verify_tag for libificationsantiago@nyu.edu, Apr 22, 2016
  6. 5/6 verify-tag: move tag verification code to tag.csantiago@nyu.edu, Apr 22, 2016
  7. Eric SunshineApr 22, 2016
  8. 6/6 tag -v: verify directly rather than exec-ing verify-tagsantiago@nyu.edu, Apr 22, 2016
  9. Eric SunshineApr 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.