git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 6/6] tag -v: verify directly rather than exec-ing verify-tag

From
santiago@nyu.edu <santiago@nyu.edu>
Date
Apr 22, 2016, 14:52 UTC
Message-ID
<1461336725-29915-7-git-send-email-santiago@nyu.edu>
In-Reply-To
<1461336725-29915-1-git-send-email-santiago@nyu.edu>
From: Santiago Torres <santiago@nyu.edu>

Instead of having tag -v fork to run verify-tag, use the gpg_verify_tag() function directly.

Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Santiago Torres <santiago@nyu.edu>
---
 builtin/tag.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index 1705c94..7b2918e 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -104,13 +104,7 @@ static int delete_tag(const char *name, const char *ref,
 static int verify_tag(const char *name, const char *ref,
 				const unsigned char *sha1)
 {
-	const char *argv_verify_tag[] = {"verify-tag",
-					"-v", "SHA1_HEX", NULL};
-	argv_verify_tag[2] = sha1_to_hex(sha1);
-
-	if (run_command_v_opt(argv_verify_tag, RUN_GIT_CMD))
-		return error(_("could not verify the tag '%s'"), name);
-	return 0;
+	return gpg_verify_tag(sha1, name, GPG_VERIFY_VERBOSE);
 }
 
 static int do_sign(struct strbuf *buffer)
-- 
2.8.0
Previous: Eric SunshineNext: Eric Sunshine
Message 8 of 9 in “Move PGP verification out of verify-tag”
  1. 0/6 Move PGP verification out of verify-tagsantiago@nyu.edu, Apr 22, 2016
  2. 1/6 builtin/verify-tag.c: ignore SIGPIPE in gpg-interfacesantiago@nyu.edu, Apr 22, 2016
  3. 2/6 t7030: test verifying multiple tagssantiago@nyu.edu, Apr 22, 2016
  4. 3/6 verify-tag: update variable name and typesantiago@nyu.edu, Apr 22, 2016
  5. 4/6 verify-tag: prepare verify_tag for libificationsantiago@nyu.edu, Apr 22, 2016
  6. 5/6 verify-tag: move tag verification code to tag.csantiago@nyu.edu, Apr 22, 2016
  7. Eric SunshineApr 22, 2016
  8. 6/6 tag -v: verify directly rather than exec-ing verify-tagsantiago@nyu.edu, Apr 22, 2016
  9. Eric SunshineApr 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.