git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mailmap: Testing the single letter name case.

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 15, 2013, 02:31 UTC
Message-ID
<CAPig+cR8zhcZ9_Gjq9mv0kPMe7F=szeSANG1b3J3gitoWCZaxA@mail.gmail.com>
In-Reply-To
<7vk3kugqkl.fsf@alter.siamese.dyndns.org>
On Sat, Jul 13, 2013 at 4:20 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> Stefan Beller <stefanbeller@googlemail.com> writes:
>
>> Indeed the patch tests for both bugs unintentionally.
>
> I was puzzled because I do not think that is what is happening with
> the posted patch.
>
> The off-by-one fix seems to be correct from code inspection, but the
> new test does not seem to demonstrate a case where the code before
> the fix misbehaves.

I've written tests which check for the two bugs which Junio's patches fix. I'll be sending them along with a re-roll of Junio's series along with a few other fixes to mailmap's debug mode.

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 14 in “Microfixes to mailmap”
  1. 0/4 Microfixes to mailmapJunio C Hamano, Jul 12, 2013
  2. 1/4 mailmap: do not lose single-letter namesJunio C Hamano, Jul 12, 2013
  3. mailmap: Testing the single letter name case.Stefan Beller, Jul 13, 2013
  4. Junio C HamanoJul 13, 2013
  5. Stefan BellerJul 13, 2013
  6. Junio C HamanoJul 13, 2013
  7. Eric SunshineJul 15, 2013
  8. Junio C HamanoJul 15, 2013
  9. Eric SunshineJul 14, 2013
  10. 2/4 mailmap: do not downcase mailmap entriesJunio C Hamano, Jul 12, 2013
  11. 3/4 mailmap: style fixesJunio C Hamano, Jul 12, 2013
  12. 4/4 add a testcase for checking case insensitivity of mailmapJunio C Hamano, Jul 12, 2013
  13. Eric SunshineJul 12, 2013
  14. Eric SunshineJul 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.