git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/4] mailmap: style fixes

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 12, 2013, 21:38 UTC
Message-ID
<1373665135-32484-4-git-send-email-gitster@pobox.com>
In-Reply-To
<1373665135-32484-1-git-send-email-gitster@pobox.com>

Wrap overlong lines and format the multi-line comments to match our coding style.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 mailmap.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/mailmap.c b/mailmap.c
index a7e92db..5a3347d 100644
--- a/mailmap.c
+++ b/mailmap.c
@@ -37,7 +37,8 @@ static void free_mailmap_info(void *p, const char *s)
 static void free_mailmap_entry(void *p, const char *s)
 {
 	struct mailmap_entry *me = (struct mailmap_entry *)p;
-	debug_mm("mailmap: removing entries for <%s>, with %d sub-entries\n", s, me->namemap.nr);
+	debug_mm("mailmap: removing entries for <%s>, with %d sub-entries\n",
+		 s, me->namemap.nr);
 	debug_mm("mailmap: - simple: '%s' <%s>\n", me->name, me->email);
 	free(me->name);
 	free(me->email);
@@ -73,7 +74,8 @@ static void add_mapping(struct string_list *map,
 	}
 
 	if (old_name == NULL) {
-		debug_mm("mailmap: adding (simple) entry for %s at index %d\n", old_email, index);
+		debug_mm("mailmap: adding (simple) entry for %s at index %d\n",
+			 old_email, index);
 		/* Replace current name and new email for simple entry */
 		if (new_name) {
 			free(me->name);
@@ -85,7 +87,8 @@ static void add_mapping(struct string_list *map,
 		}
 	} else {
 		struct mailmap_info *mi = xcalloc(1, sizeof(struct mailmap_info));
-		debug_mm("mailmap: adding (complex) entry for %s at index %d\n", old_email, index);
+		debug_mm("mailmap: adding (complex) entry for %s at index %d\n",
+			 old_email, index);
 		if (new_name)
 			mi->name = xstrdup(new_name);
 		if (new_email)
@@ -315,8 +318,10 @@ int map_user(struct string_list *map,
 	if (item != NULL) {
 		me = (struct mailmap_entry *)item->util;
 		if (me->namemap.nr) {
-			/* The item has multiple items, so we'll look up on name too */
-			/* If the name is not found, we choose the simple entry      */
+			/*
+			 * The item has multiple items, so we'll look up on name too.
+			 * If the name is not found, we choose the simple entry.
+			 */
 			struct string_list_item *subitem;
 			subitem = lookup_prefix(&me->namemap, *name, *namelen);
 			if (subitem)
-- 
1.8.3.2-941-gda9c3c8
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 14 in “Microfixes to mailmap”
  1. 0/4 Microfixes to mailmapJunio C Hamano, Jul 12, 2013
  2. 1/4 mailmap: do not lose single-letter namesJunio C Hamano, Jul 12, 2013
  3. mailmap: Testing the single letter name case.Stefan Beller, Jul 13, 2013
  4. Junio C HamanoJul 13, 2013
  5. Stefan BellerJul 13, 2013
  6. Junio C HamanoJul 13, 2013
  7. Eric SunshineJul 15, 2013
  8. Junio C HamanoJul 15, 2013
  9. Eric SunshineJul 14, 2013
  10. 2/4 mailmap: do not downcase mailmap entriesJunio C Hamano, Jul 12, 2013
  11. 3/4 mailmap: style fixesJunio C Hamano, Jul 12, 2013
  12. 4/4 add a testcase for checking case insensitivity of mailmapJunio C Hamano, Jul 12, 2013
  13. Eric SunshineJul 12, 2013
  14. Eric SunshineJul 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.