git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] send-email: add an auto option for transfer encoding

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 6, 2018, 06:01 UTC
Message-ID
<CAPig+cR7tWw7D8JMg1a9G2Jgi=HQj3YZjCn+tHDNjDEsrfSLqg@mail.gmail.com>
In-Reply-To
<20180706022357.739657-2-sandals@crustytoothpaste.net>

On Thu, Jul 5, 2018 at 10:24 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 17 quoted lines
> For most patches, using a transfer encoding of 8bit provides good
> compatibility with most servers and makes it as easy as possible to view
> patches.  However, there are some patches for which 8bit is not a valid
> encoding: RFC 5321 specifies that a message must not have lines
> exceeding 998 octets.
>
> Add a transfer encoding value, auto, which indicates that a patch should
> use 8bit where allowed and quoted-printable otherwise.  Choose
> quoted-printable instead of base64, since base64-encoded plain text is
> treated as suspicious by some spam filters.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> diff --git a/git-send-email.perl b/git-send-email.perl
> @@ -1852,13 +1851,16 @@ sub apply_transfer_encoding {
> +       $to = ($message =~ /.{999,}/) ? 'quoted-printable' :'8bit'
> +               if $to eq 'auto';
Style: space after colon: 'quoted-printable' : '8bit'
Show 11 quoted lines
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> +test_expect_success $PREREQ 'long lines with auto encoding are quoted-printable' '
> +       clean_fake_sendmail &&
> +       git send-email \
> +               --from="Example <nobody@example.com>" \
> +               --to=nobody@example.com \
> +               --smtp-server="$(pwd)/fake.sendmail" \
> +               --transfer-encoding=auto \
> +               --no-validate \
> +               longline.patch \
> +               2>errors &&
Why capture stderr to a file then ignore the file?
> +       grep "Content-Transfer-Encoding: quoted-printable" msgtxt1
> +'
Previous: brian m. carlsonNext: brian m. carlson
Message 3 of 16 in “Automatic transfer encoding for patches”
  1. 0/3 Automatic transfer encoding for patchesbrian m. carlson, Jul 6, 2018
  2. 1/3 send-email: add an auto option for transfer encodingbrian m. carlson, Jul 6, 2018
  3. Eric SunshineJul 6, 2018
  4. brian m. carlsonJul 6, 2018
  5. 3/3 send-email: automatically determine transfer-encodingbrian m. carlson, Jul 6, 2018
  6. 2/3 send-email: accept long lines with suitable transfer encodingbrian m. carlson, Jul 6, 2018
  7. Eric SunshineJul 6, 2018
  8. Drew DeVaultJul 6, 2018
  9. brian m. carlsonJul 6, 2018
  10. Drew DeVaultJul 6, 2018
  11. 0/4 Automatic transfer encoding for patchesbrian m. carlson, Jul 8, 2018
  12. 1/4 send-email: add an auto option for transfer encodingbrian m. carlson, Jul 8, 2018
  13. 2/4 send-email: accept long lines with suitable transfer encodingbrian m. carlson, Jul 8, 2018
  14. 4/4 docs: correct RFC specifying email line lengthbrian m. carlson, Jul 8, 2018
  15. 3/4 send-email: automatically determine transfer-encodingbrian m. carlson, Jul 8, 2018
  16. Drew DeVaultJul 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.