Re: [PATCH 2/3] send-email: accept long lines with suitable transfer encoding
- From
Drew DeVault <sir@cmpwn.com>
- Date
- Jul 6, 2018, 12:26 UTC
- Message-ID
- <20180706122604.GA9255@homura.localdomain>
- In-Reply-To
- <20180706022357.739657-3-sandals@crustytoothpaste.net>
On 2018-07-06 2:23 AM, brian m. carlson wrote:
Show 11 quoted lines
> diff --git a/git-send-email.perl b/git-send-email.perl
> index a76953c310..4ea30c4070 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1899,6 +1899,10 @@ sub validate_patch {
> return $hook_error if $hook_error;
> }
>
> + # Any long lines will be automatically fixed if we use a suitable transfer
> + # encoding.
> + return if $xfer_encoding =~ /^(?:auto|quoted-printable|base64)$/;Rather than returning in this case I'd sooner wrap the length check in this test. If additional checks are added in the future it'd be too easy to accidentally skip them if the transfer encoding is quoted-printable.