Re: [ANNOUNCE] Git v2.7.4 (and updates to older maintenance tracks)

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 21, 2016, 04:41 UTC
Message-ID: <CAPig+cR7d0UF08fQy5uXW8U+7rdjGSO1drMxm6LOV-KB40mwPw@mail.gmail.com>
In-Reply-To: <20160320194313.GB6288@sigill.intra.peff.net>

[cc:+Torsten]

On Sun, Mar 20, 2016 at 3:43 PM, Jeff King <peff@peff.net> wrote:

Show 18 quoted lines

> On Sun, Mar 20, 2016 at 01:07:52PM -0400, Eric Sunshine wrote:
>> On Sun, Mar 20, 2016 at 11:32 AM, Renato Botelho <garga@freebsd.org> wrote:
>> > 2.7.4 fails to build on FreeBSD 9.x, that uses by default gcc 4.2.1. I’ve fixed it adding an extra dependency to make force it to require gcc 4.8+. Here is the output:
>> >
>> > combine-diff.c: In function 'diff_tree_combined':
>> > combine-diff.c:1391: internal compiler error: Segmentation fault: 11
>>
>> Interesting. This appears to be the same bug as [1].
>>
>> [1]: http://thread.gmane.org/gmane.comp.version-control.git/287486/focus=287789
>
> Yes. AFAICT that version of gcc is simply buggy, and we are not doing
> anything illegal or even particularly exotic. Given how old it is, I'm
> not sure it's worth worrying too much about it, but I am happy to work
> around it if somebody can figure out how to do so.
>
> I spent some time trying to bisect gcc, but had trouble getting a
> working build for a gcc that old.

I installed FreeBSD 9 and managed to reproduce the compiler crash. After a bit of experimentation, I devised a simple work-around and submitted it as a patch[1].

[1]: http://thread.gmane.org/gmane.comp.version-control.git/289397