Re: [ANNOUNCE] Git v2.7.4 (and updates to older maintenance tracks)

From: Jeff King <peff@peff.net>
Date: Mar 20, 2016, 19:43 UTC
Message-ID: <20160320194313.GB6288@sigill.intra.peff.net>
In-Reply-To: <CAPig+cSOjFqcKGaZC1HWGdp7aCg7Dog1GvFYPYRbShARPm9ODQ@mail.gmail.com>

On Sun, Mar 20, 2016 at 01:07:52PM -0400, Eric Sunshine wrote:

Show 27 quoted lines

> On Sun, Mar 20, 2016 at 11:32 AM, Renato Botelho <garga@freebsd.org> wrote:
> >> On Mar 17, 2016, at 18:07, Junio C Hamano <gitster@pobox.com> wrote:
> >> Git v2.7.4 Release Notes
> >>
> >> Junio C Hamano (4):
> >>      Git 2.4.11
> >>      Git 2.5.5
> >>      Git 2.6.6
> >>      Git 2.7.4
> >
> > FYI,
> >
> > 2.7.4 fails to build on FreeBSD 9.x, that uses by default gcc 4.2.1. I’ve fixed it adding an extra dependency to make force it to require gcc 4.8+. Here is the output:
> >
> > cc -o combine-diff.o -c -MF ./.depend/combine-diff.o.d -MQ combine-diff.o -MMD -MP -isystem/usr/local/include -O2 -pipe -fstack-protector -fno-strict-aliasing -I. -I/usr/local/include -I/usr/local/include -DUSE_CURL_FOR_IMAP_SEND -I/usr/include -DUSE_ST_TIMESPEC -pthread -DHAVE_PATHS_H -DHAVE_STRINGS_H -DGMTIME_UNRELIABLE_ERRORS -DHAVE_CLOCK_GETTIME -DHAVE_CLOCK_MONOTONIC -DHAVE_BSD_SYSCTL -DHAVE_GETDELIM -DSHA1_HEADER='<openssl/sha.h>'  -DDIR_HAS_BSD_GROUP_SEMANTICS -DSHELL_PATH='"/bin/sh"'  combine-diff.c
> > combine-diff.c: In function 'diff_tree_combined':
> > combine-diff.c:1391: internal compiler error: Segmentation fault: 11
> > Please submit a full bug report,
> > with preprocessed source if appropriate.
> > See <URL:http://gcc.gnu.org/bugs.html> for instructions.
> > Makefile:1924: recipe for target 'combine-diff.o' failed
> > gmake: *** [combine-diff.o] Error 1
> > *** [do-build] Error code 1
> 
> Interesting. This appears to be the same bug as [1].
> 
> [1]: http://thread.gmane.org/gmane.comp.version-control.git/287486/focus=287789

Yes. AFAICT that version of gcc is simply buggy, and we are not doing anything illegal or even particularly exotic. Given how old it is, I'm not sure it's worth worrying too much about it, but I am happy to work around it if somebody can figure out how to do so.

I spent some time trying to bisect gcc, but had trouble getting a working build for a gcc that old.

-Peff