Re: [RFC PATCH] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Mar 16, 2018, 21:44 UTC
- Message-ID
- <CAPig+cR5ncp9eMZ8krgy19A6g1Uqjx9dXTkus4r1QimD5Uwk0A@mail.gmail.com>
- In-Reply-To
- <20180316213323.GC2224@hank>
On Fri, Mar 16, 2018 at 5:33 PM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
Show 18 quoted lines
> Subject: [PATCH] SubmittingPatches: mention the git contacts command > > Instead of just mentioning 'git blame' and 'git shortlog', which make > it harder than necessary for new contributors to pick out the > appropriate list of people to cc on their patch series, mention the > 'git contacts' utility, which should make it much easier to get a > reasonable list of contacts for a change. > > Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com> > --- > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > @@ -260,8 +260,8 @@ that starts with `-----BEGIN PGP SIGNED MESSAGE-----`. That is > Send your patch with "To:" set to the mailing list, with "cc:" listing > -people who are involved in the area you are touching (the output from > -`git blame $path` and `git shortlog --no-merges $path` would help to > +people who are involved in the area you are touching (the `git > +contacts` command in `contrib/contacts/` can help to > identify them), to solicit comments and reviews.
It may be a disservice to remove mention of git-blame and git-shortlog since git-contacts may not be suitable for everyone. Instead, perhaps advertise git-contacts as a potentially simpler alternative to the already-mentioned git-blamd & git-shortlog?
Also, would it make sense to mention Felipe's git-related[1] which is the original (and now more configurable) script from which git-contacts functionality was derived?
[1]: https://github.com/felipec/git-related