Re: [RFC PATCH] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default
- From
Thomas Gummerer <t.gummerer@gmail.com>
- Date
- Mar 16, 2018, 21:33 UTC
- Message-ID
- <20180316213323.GC2224@hank>
- In-Reply-To
- <CAK0XTWdY6rfKu_s8Am6dh9njcFHqSAz_54PhW6V09DuGwE-h0g@mail.gmail.com>
On 03/08, Eddy Petrișor wrote:
Show 29 quoted lines
> 2018-03-06 22:21 GMT+02:00 Jonathan Nieder <jrnieder@gmail.com>: > > > > (cc list snipped) > > Hi, > > > > Eddy Petrișor wrote: > > > > > Cc: [a lot of people] > > > > Can you say a little about how this cc list was created? E.g. should > > "git send-email" get a feature to warn about long cc lists? > > > I did it as advised by the documentation, git blame: > > https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L264 > > I was suprised that there is no specialized script that does this, as > it is for the kernel or u-boot, so I ran first > > git log --pretty=format:'%an <%ae>' git-submodule.sh | sort -u > > mail-list-submodule > > then configure git to use that custom output and ignore the patch > since it was trying to convert every line of it into a email address: > > git config sendemail.ccCmd 'cat mail-list-submodule # ' > > Then "git send-email 0001..." did the rest.
There's a 'git contacts' command which we've been carrying in "contrib/" for a while. Maybe we could advertise that in "Documentation/SubmittingPatches" instead of 'git blame' and 'git shortlog'?
Maybe something like the patch below?
--- >8 --- Subject: [PATCH] SubmittingPatches: mention the git contacts command
Instead of just mentioning 'git blame' and 'git shortlog', which make it harder than necessary for new contributors to pick out the appropriate list of people to cc on their patch series, mention the 'git contacts' utility, which should make it much easier to get a reasonable list of contacts for a change.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com> --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index a1d0feca36..945f8edb46 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -260,8 +260,8 @@ that starts with `-----BEGIN PGP SIGNED MESSAGE-----`. That is not a text/plain, it's something else. Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the output from -`git blame $path` and `git shortlog --no-merges $path` would help to +people who are involved in the area you are touching (the `git +contacts` command in `contrib/contacts/` can help to identify them), to solicit comments and reviews. :1: footnote:[The current maintainer: gitster@pobox.com]
-- 2.16.2.804.g6dcf76e11