git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 9/9] fixup! t5512: stop losing git exit code in here-docs

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 27, 2020, 20:29 UTC
Message-ID
<CAPig+cR0rNnVRF-Xei-n2HaxLR=9yF=7aya3mdApaqfEXmcPLg@mail.gmail.com>
In-Reply-To
<xmqqimipherm.fsf@gitster.c.googlers.com>
On Fri, Mar 27, 2020 at 1:46 PM Junio C Hamano <gitster@pobox.com> wrote:
> > Subject: Re: [PATCH v2 9/9] fixup! t5512: stop losing git exit code in here-docs
>
> Forgot to do the final "rebase -i --autosquash"?

My guess is that Denton sent this "fixup!" to have it queued atop [1] in response to the review comment[2] pointing out the bad indentation (rather than re-sending the entire series just for one minor change).

[1]: https://lore.kernel.org/git/cover.1585209554.git.liu.denton@gmail.com/ [2]: https://lore.kernel.org/git/CAPig+cTpV2n66nYJdQpG0tYCu5f=PB-a9Boa_NNfVaUOshDVug@mail.gmail.com/

Previous: Junio C HamanoNext: Junio C Hamano
Message 29 of 30 in “t: replace incorrect test_must_fail usage (part 3)”
  1. 0/8 t: replace incorrect test_must_fail usage (part 3)Denton Liu, Mar 25, 2020
  2. 1/8 t5512: don't use `test_must_fail test_cmp`Denton Liu, Mar 25, 2020
  3. 3/8 t5512: stop losing return codes of git commandsDenton Liu, Mar 25, 2020
  4. 2/8 t5512: generate references with generate_references()Denton Liu, Mar 25, 2020
  5. Eric SunshineMar 25, 2020
  6. Junio C HamanoMar 25, 2020
  7. 5/8 t5607: reorder `nongit test_must_fail`Denton Liu, Mar 25, 2020
  8. 4/8 t5550: remove use of `test_might_fail grep`Denton Liu, Mar 25, 2020
  9. Junio C HamanoMar 25, 2020
  10. 8/8 t5801: teach compare_refs() to accept !Denton Liu, Mar 25, 2020
  11. Junio C HamanoMar 25, 2020
  12. Eric SunshineMar 25, 2020
  13. 7/8 t5612: stop losing return codes of git commandsDenton Liu, Mar 25, 2020
  14. 6/8 t5612: don't use `test_must_fail test_cmp`Denton Liu, Mar 25, 2020
  15. Junio C HamanoMar 25, 2020
  16. 0/8 t: replace incorrect test_must_fail usage (part 3)Denton Liu, Mar 26, 2020
  17. 1/8 t5512: don't use `test_must_fail test_cmp`Denton Liu, Mar 26, 2020
  18. 2/8 t5512: stop losing git exit code in here-docsDenton Liu, Mar 26, 2020
  19. Eric SunshineMar 26, 2020
  20. 3/8 t5512: stop losing return codes of git commandsDenton Liu, Mar 26, 2020
  21. 4/8 t5550: simplify no matching line checkDenton Liu, Mar 26, 2020
  22. Eric SunshineMar 26, 2020
  23. 5/8 t5607: reorder `nongit test_must_fail`Denton Liu, Mar 26, 2020
  24. 6/8 t5612: don't use `test_must_fail test_cmp`Denton Liu, Mar 26, 2020
  25. 7/8 t5612: stop losing return codes of git commandsDenton Liu, Mar 26, 2020
  26. 8/8 t5801: teach compare_refs() to accept !Denton Liu, Mar 26, 2020
  27. 9/9 fixup! t5512: stop losing git exit code in here-docsDenton Liu, Mar 27, 2020
  28. Junio C HamanoMar 27, 2020
  29. Eric SunshineMar 27, 2020
  30. Junio C HamanoMar 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.