Re: [PATCH 6/9] send-email: simplify sendmail aliases comment and blank line recognizer

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 1, 2015, 03:30 UTC
Message-ID: <CAPig+cR=_3Bb4NOb=4uD8sokhU_n6=5nh3WdvTH5_yL_t_uung@mail.gmail.com>
In-Reply-To: <1433111371-19573-7-git-send-email-sunshine@sunshineco.com>

On Sun, May 31, 2015 at 6:29 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

> Replace unnecessarily complex regular expression for recognizing comment
> and blanks lines in sendmail aliases with idiomatic expressions which

s/blanks/blank/

Show 22 quoted lines

> can be easily understood at a glance.
>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
>  git-send-email.perl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 76bb499..e777bd3 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -505,7 +505,7 @@ sub parse_sendmail_alias {
>  sub parse_sendmail_aliases {
>         my $fh = shift;
>         while (<$fh>) {
> -               if (/^\s*(?:#.*)?$/) { next; }
> +               next if /^\s*$/ || /^\s*#/;
>                 parse_sendmail_alias($_);
>         }
>  }
> --
> 2.4.2.538.g5f4350e