[PATCH 2/9] send-email: visually distinguish sendmail aliases parser warnings
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- May 31, 2015, 22:29 UTC
- Message-ID
- <1433111371-19573-3-git-send-email-sunshine@sunshineco.com>
- In-Reply-To
- <1433111371-19573-1-git-send-email-sunshine@sunshineco.com>
Although emitted to stderr, warnings from the sendmail aliases parser are not visually distinguished as such, and thus can easily be overlooked in the normal noisy send-email output.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> ---
This prepends lowercase "warning:" rather than uppercase since lowercase is used elsewhere in git-send-email.perl for diagnostic message prefixes.
git-send-email.perl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index 6bedf74..819f87e 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -522,12 +522,12 @@ my %parse_alias = ( # warn on lines that contain quotes elsif (/"/) { - print STDERR "sendmail alias with quotes is not supported: $_\n"; + print STDERR "warning: sendmail alias with quotes is not supported: $_\n"; } # warn on lines that continue elsif (/^\s|\\$/) { - print STDERR "sendmail continuation line is not supported: $_\n"; + print STDERR "warning: sendmail continuation line is not supported: $_\n"; } # recognize lines that look like an alias @@ -538,7 +538,7 @@ my %parse_alias = ( # warn on lines that are not recognized else { - print STDERR "sendmail line is not recognized: $_\n"; + print STDERR "warning: sendmail line is not recognized: $_\n"; }}}, gnus => sub { my $fh = shift; while (<$fh>) {
-- 2.4.2.538.g5f4350e