Re: [PATCH v5 1/1] contrib/subtree: Add a test for subtree rebase that loses commits
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jan 19, 2016, 04:21 UTC
- Message-ID
- <CAPig+cQyn-TGocV8Z6UTCJtBZMT8-HCtV7HqqJ+yinaczGUPvg@mail.gmail.com>
- In-Reply-To
- <3eb25268597083cdb10303e3d5790302e719a803.1453172369.git.greened@obbligato.org>
On Mon, Jan 18, 2016 at 9:59 PM, David Greene <greened@obbligato.org> wrote:
Show 16 quoted lines
> This test merges an external tree in as a subtree, makes some commits > on top of it and splits it back out. In the process the added commits > are lost or the rebase aborts with an internal error. The tests are > marked to expect failure so that we don't forget to fix it. > > Signed-off-by: David A. Greene <greened@obbligato.org> > --- > Notes: > Change History: > > v1 - Initial version > v2 - Additional tests and code cleanup > v3 - Remove check_equal, mark comments on failure and remove > test_debug statements > v4 - Send correct v3 test (botched v3) > v5 - Fix use of verbose
Thanks, I think this re-roll addresses all the (relatively superficial) issues raised by my reviews of previous versions.