git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 1/1] contrib/subtree: Add a test for subtree rebase that loses commits

From
David Greene <greened@obbligato.org>
Date
Jan 19, 2016, 02:59 UTC
Message-ID
<3eb25268597083cdb10303e3d5790302e719a803.1453172369.git.greened@obbligato.org>
In-Reply-To
<CAPig+cS6ouc+kdJaz10M2AApPoDODDcgDX9Azz8ih=4zxxD2zg@mail.gmail.com>
From: David A. Greene <greened@obbligato.org>

This test merges an external tree in as a subtree, makes some commits on top of it and splits it back out. In the process the added commits are lost or the rebase aborts with an internal error. The tests are marked to expect failure so that we don't forget to fix it.

Signed-off-by: David A. Greene <greened@obbligato.org>
---
Notes:
    Change History:
    
    v1 - Initial version
    v2 - Additional tests and code cleanup
    v3 - Remove check_equal, mark comments on failure and remove
         test_debug statements
    v4 - Send correct v3 test (botched v3)
    v5 - Fix use of verbose
 t/t3427-rebase-subtree.sh | 70 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)
diff --git a/t/t3427-rebase-subtree.sh b/t/t3427-rebase-subtree.sh
new file mode 100755
index 0000000..a68a1b1
--- /dev/null
+++ b/t/t3427-rebase-subtree.sh
@@ -0,0 +1,70 @@
+#!/bin/sh
+
+test_description='git rebase tests for -Xsubtree
+
+This test runs git rebase and tests the subtree strategy.
+'
+. ./test-lib.sh
+. "$TEST_DIRECTORY"/lib-rebase.sh
+
+last_commit_message() {
+	git log --pretty=format:%s -1
+}
+
+test_expect_success 'setup' '
+	test_commit README &&
+	mkdir files &&
+	(
+		cd files &&
+		git init &&
+		test_commit master1 &&
+		test_commit master2 &&
+		test_commit master3
+	) &&
+	git fetch files master &&
+	git branch files-master FETCH_HEAD &&
+	git read-tree --prefix=files_subtree files-master &&
+	git checkout -- files_subtree &&
+	tree=$(git write-tree) &&
+	head=$(git rev-parse HEAD) &&
+	rev=$(git rev-parse --verify files-master^0) &&
+	commit=$(git commit-tree -p $head -p $rev -m "Add subproject master" $tree) &&
+	git reset $commit &&
+	(
+		cd files_subtree &&
+		test_commit master4
+	) &&
+	test_commit files_subtree/master5
+'
+
+# FAILURE: Does not preserve master4 and master5.
+test_expect_failure 'Rebase -Xsubtree --preserve-merges --onto' '
+	reset_rebase &&
+	git checkout -b rebase-preserve-merges master &&
+	git filter-branch --prune-empty -f --subdirectory-filter files_subtree &&
+	git commit -m "Empty commit" --allow-empty &&
+	git rebase -Xsubtree=files_subtree --preserve-merges --onto files-master master &&
+	verbose test "$(last_commit_message)" = "files_subtree/master5"
+'
+
+# FAILURE: Does not preserve master4, master5 and empty.
+test_expect_failure 'Rebase -Xsubtree --keep-empty --preserve-merges --onto' '
+	reset_rebase &&
+	git checkout -b rebase-keep-empty master &&
+	git filter-branch --prune-empty -f --subdirectory-filter files_subtree &&
+	git commit -m "Empty commit" --allow-empty &&
+	git rebase -Xsubtree=files_subtree --keep-empty --preserve-merges --onto files-master master &&
+	verbose test "$(last_commit_message)" = "Empty commit"
+'
+
+# FAILURE: fatal: Could not parse object
+test_expect_failure 'Rebase -Xsubtree --onto' '
+	reset_rebase &&
+	git checkout -b rebase-onto master &&
+	git filter-branch --prune-empty -f --subdirectory-filter files_subtree &&
+	git commit -m "Empty commit" --allow-empty &&
+	git rebase -Xsubtree=files_subtree --onto files-master master &&
+	verbose test "$(last_commit_message)" = "Empty commit"
+'
+
+test_done
-- 
2.6.1
Previous: David A. GreeneNext: Eric Sunshine
Message 18 of 24 in “Test rebase -Xsubtree”
  1. Test rebase -XsubtreeDavid Greene, Jan 5, 2016
  2. Add a test for subtree rebase that loses commitsDavid Greene, Jan 5, 2016
  3. Torsten BögershausenJan 5, 2016
  4. Dennis KaarsemakerJan 5, 2016
  5. Torsten BögershausenJan 5, 2016
  6. Eric SunshineJan 5, 2016
  7. David A. GreeneJan 5, 2016
  8. Test rebase -XsubtreeDavid Greene, Jan 10, 2016
  9. Add a test for subtree rebase that loses commitsDavid Greene, Jan 10, 2016
  10. Eric SunshineJan 15, 2016
  11. David A. GreeneJan 17, 2016
  12. 1/1 Add a test for subtree rebase that loses commitsDavid Greene, Jan 17, 2016
  13. Eric SunshineJan 17, 2016
  14. David A. GreeneJan 17, 2016
  15. 1/1 contrib/subtree: Add a test for subtree rebase that loses commitsDavid Greene, Jan 17, 2016
  16. Eric SunshineJan 18, 2016
  17. David A. GreeneJan 19, 2016
  18. 1/1 contrib/subtree: Add a test for subtree rebase that loses commitsDavid Greene, Jan 19, 2016
  19. Eric SunshineJan 19, 2016
  20. Junio C HamanoJan 19, 2016
  21. David A. GreeneJan 20, 2016
  22. Junio C HamanoApr 12, 2016
  23. David A. GreeneJun 28, 2016
  24. 1/1 contrib/subtree: Add a test for subtree rebase that loses commitsDavid Greene, Jun 28, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.