Re: contrib/diff-highlight: stop hard-coding perl location

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Feb 22, 2016, 07:13 UTC
Message-ID: <CAPig+cQp9H4K2D88bVxRRnwD_rY-8hROzVOp6aBCp9Y=Y6HwUA@mail.gmail.com>
In-Reply-To: <CA+boQ6bCH35hu9GfQY_P5bNZCdJ8Knr8zQ+S41RGF0z-JamVgw@mail.gmail.com>

[please don't top-post on this list]

On Mon, Feb 22, 2016 at 1:49 AM, Peter Dave Hello <hsu@peterdavehello.org> wrote:

> Thank you, is there anything I should do? Or I should just wait?

Best is to wait for other review comments, particularly from Junio. Reviewers work at their own pace as time permits, so don't be surprised if it takes days or a week or more. If you don't hear back from Junio after a week or two, and if you don't see that he has silently picked it up in his "pu" branch and don't see mention of it in Junio's "What's cooking" email after that time, then it can be helpful to send a reminder about the patch to the list.

Show 33 quoted lines

> Best,
> Peter
>
> 2016/2/22 下午1:56於 "Eric Sunshine" <sunshine@sunshineco.com>寫道：
>>
>> On Mon, Feb 22, 2016 at 12:54 AM, Peter Dave Hello
>> <hsu@peterdavehello.org> wrote:
>> > From: Peter Dave Hello <hsu@peterdavehello.org>
>> >
>> > Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`,
>> > the util "env" can help located the "perl",
>> > so that it can work on FreeBSD and other platforms.
>> >
>> > Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
>>
>> Better, thanks.
>>
>> > ---
>> >  contrib/diff-highlight/diff-highlight | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/contrib/diff-highlight/diff-highlight
>> > b/contrib/diff-highlight/diff-highlight
>> > index ffefc31..b57b0fd 100755
>> > --- a/contrib/diff-highlight/diff-highlight
>> > +++ b/contrib/diff-highlight/diff-highlight
>> > @@ -1,4 +1,4 @@
>> > -#!/usr/bin/perl
>> > +#!/usr/bin/env perl
>> >
>> >  use 5.008;
>> >  use warnings FATAL => 'all';
>